diff --git a/Minecraft.Client/Chunk.cpp b/Minecraft.Client/Chunk.cpp index dddb628b..fd27733c 100644 --- a/Minecraft.Client/Chunk.cpp +++ b/Minecraft.Client/Chunk.cpp @@ -402,6 +402,7 @@ void Chunk::rebuild() } Tile *tile = Tile::tiles[tileId]; + if (!tile) continue; if (currentLayer == 0 && tile->isEntityTile()) { shared_ptr et = region->getTileEntity(x, y, z); @@ -739,9 +740,9 @@ void Chunk::rebuild_SPU() { // 4J - get tile from those copied into our local array in earlier optimisation unsigned char tileId = pOutData->getTile(x,y,z); - if (tileId > 0) + if (tileId > 0 && tileId != 0xff) { - if (currentLayer == 0 && Tile::tiles[tileId]->isEntityTile()) + if (currentLayer == 0 && Tile::tiles[tileId] && Tile::tiles[tileId]->isEntityTile()) { shared_ptr et = region.getTileEntity(x, y, z); if (TileEntityRenderDispatcher::instance->hasRenderer(et)) @@ -754,6 +755,7 @@ void Chunk::rebuild_SPU() { Tile *tile = Tile::tiles[tileId]; + if (!tile) continue; int renderLayer = tile->getRenderLayer(); if (renderLayer != currentLayer) diff --git a/Minecraft.Client/ClientConnection.cpp b/Minecraft.Client/ClientConnection.cpp index d44995e9..b7e7f6dd 100644 --- a/Minecraft.Client/ClientConnection.cpp +++ b/Minecraft.Client/ClientConnection.cpp @@ -776,6 +776,7 @@ void ClientConnection::handleAddPlayer(shared_ptr packet) player->yRotp = packet->yRot; player->yHeadRot = packet->yHeadRot * 360 / 256.0f; player->setXuid(packet->xuid); + player->setOnlineXuid(packet->OnlineXuid); #ifdef _DURANGO // On Durango request player display name from network manager @@ -788,11 +789,11 @@ void ClientConnection::handleAddPlayer(shared_ptr packet) #if defined _WINDOWS64 || defined DISABLE_PSN || defined _DISABLE_XBLIVE { - PlayerUID pktXuid = player->getXuid(); + PlayerUID netXuid = packet->OnlineXuid; const PlayerUID WIN64_XUID_BASE = (PlayerUID)0xe000d45248242f2e; - if (pktXuid >= WIN64_XUID_BASE && pktXuid < WIN64_XUID_BASE + MINECRAFT_NET_MAX_PLAYERS) + if (netXuid >= WIN64_XUID_BASE && netXuid < WIN64_XUID_BASE + MINECRAFT_NET_MAX_PLAYERS) { - BYTE smallId = (BYTE)(pktXuid - WIN64_XUID_BASE); + BYTE smallId = (BYTE)(netXuid - WIN64_XUID_BASE); INetworkPlayer *np = g_NetworkManager.GetPlayerBySmallId(smallId); if (np != NULL) { @@ -954,39 +955,6 @@ void ClientConnection::handleMoveEntitySmall(shared_ptr p void ClientConnection::handleRemoveEntity(shared_ptr packet) { -#if defined _WINDOWS64 || defined DISABLE_PSN || defined _DISABLE_XBLIVE - if (!g_NetworkManager.IsHost()) - { - for (int i = 0; i < packet->ids.length; i++) - { - shared_ptr entity = getEntity(packet->ids[i]); - if (entity != NULL && entity->GetType() == eTYPE_PLAYER) - { - shared_ptr player = dynamic_pointer_cast(entity); - if (player != NULL) - { - PlayerUID xuid = player->getXuid(); - INetworkPlayer *np = g_NetworkManager.GetPlayerByXuid(xuid); - if (np != NULL) - { - NetworkPlayerXbox *npx = (NetworkPlayerXbox *)np; - IQNetPlayer *qp = npx->GetQNetPlayer(); - if (qp != NULL) - { - extern CPlatformNetworkManagerStub *g_pPlatformNetworkManager; - g_pPlatformNetworkManager->NotifyPlayerLeaving(qp); - qp->m_smallId = 0; - qp->m_isRemote = false; - qp->m_isHostPlayer = false; - qp->m_gamertag[0] = 0; - qp->SetCustomDataValue(0); - } - } - } - } - } - } -#endif for (int i = 0; i < packet->ids.length; i++) { level->removeEntity(packet->ids[i]); @@ -1068,6 +1036,7 @@ void ClientConnection::handleChunkVisibility(shared_ptr p void ClientConnection::handleChunkTilesUpdate(shared_ptr packet) { // 4J - changed to encode level in packet + if (packet->levelIdx >= minecraft->levels.length) return; MultiPlayerLevel *dimensionLevel = (MultiPlayerLevel *)minecraft->levels[packet->levelIdx]; if( dimensionLevel ) { @@ -1137,6 +1106,7 @@ void ClientConnection::handleChunkTilesUpdate(shared_ptr void ClientConnection::handleBlockRegionUpdate(shared_ptr packet) { // 4J - changed to encode level in packet + if (packet->levelIdx >= minecraft->levels.length) return; MultiPlayerLevel *dimensionLevel = (MultiPlayerLevel *)minecraft->levels[packet->levelIdx]; if( dimensionLevel ) { @@ -1194,6 +1164,8 @@ void ClientConnection::handleTileUpdate(shared_ptr packet) destroyTilePacket = true; } // 4J - changed to encode level in packet + if (packet->levelIdx >= minecraft->levels.length) return; + MultiPlayerLevel *dimensionLevel = (MultiPlayerLevel *)minecraft->levels[packet->levelIdx]; if( dimensionLevel ) { @@ -2350,6 +2322,7 @@ void ClientConnection::handleAddMob(shared_ptr packet) float xRot = packet->xRot * 360 / 256.0f; shared_ptr mob = dynamic_pointer_cast(EntityIO::newById(packet->type, level)); + if (mob == NULL) return; mob->xp = packet->x; mob->yp = packet->y; mob->zp = packet->z; @@ -3593,10 +3566,12 @@ void ClientConnection::handleCustomPayload(shared_ptr custo } #else UIScene *scene = ui.GetTopScene(m_userIndex, eUILayer_Scene); - UIScene_TradingMenu *screen = (UIScene_TradingMenu *)scene; - trader = screen->getMerchant(); + UIScene_TradingMenu *screen = dynamic_cast(scene); + if (screen != NULL) + trader = screen->getMerchant(); #endif + if (trader == NULL) return; MerchantRecipeList *recipeList = MerchantRecipeList::createFromStream(&input); trader->overrideOffers(recipeList); } diff --git a/Minecraft.Client/Common/Network/NetworkSocketLayer.cpp b/Minecraft.Client/Common/Network/NetworkSocketLayer.cpp index a17aae00..2c5acccf 100644 --- a/Minecraft.Client/Common/Network/NetworkSocketLayer.cpp +++ b/Minecraft.Client/Common/Network/NetworkSocketLayer.cpp @@ -39,7 +39,7 @@ BYTE NetworkSocketLayer::s_nextSmallId = 1; CRITICAL_SECTION NetworkSocketLayer::s_sendLock; CRITICAL_SECTION NetworkSocketLayer::s_connectionsLock; -std::vector NetworkSocketLayer::s_connections; +RemoteConnection NetworkSocketLayer::s_connections[NETWORK_LAN_MAX_CLIENTS + 1]; C4JThread* NetworkSocketLayer::s_advertiseThread = NULL; volatile bool NetworkSocketLayer::s_advertising = false; @@ -55,6 +55,9 @@ std::vector NetworkSocketLayer::s_discoveredSessions; CRITICAL_SECTION NetworkSocketLayer::s_disconnectLock; std::vector NetworkSocketLayer::s_disconnectedSmallIds; +CRITICAL_SECTION NetworkSocketLayer::s_pendingJoinLock; +std::vector NetworkSocketLayer::s_pendingJoinSmallIds; + CRITICAL_SECTION NetworkSocketLayer::s_freeSmallIdLock; std::vector NetworkSocketLayer::s_freeSmallIds; @@ -83,7 +86,17 @@ bool NetworkSocketLayer::Initialize() InitializeCriticalSection(&s_advertiseLock); InitializeCriticalSection(&s_discoveryLock); InitializeCriticalSection(&s_disconnectLock); + InitializeCriticalSection(&s_pendingJoinLock); InitializeCriticalSection(&s_freeSmallIdLock); + + for (int i = 0; i < NETWORK_LAN_MAX_CLIENTS + 1; i++) + { + s_connections[i].tcpSocket = INVALID_SOCKET; + s_connections[i].smallId = 0; + s_connections[i].recvThread = NULL; + s_connections[i].active = false; + InitializeCriticalSection(&s_connections[i].sendLock); + } s_locksCreated = true; } @@ -167,7 +180,7 @@ void NetworkSocketLayer::Shutdown() EnterCriticalSection(&s_connectionsLock); - for (size_t i = 0; i < s_connections.size(); i++) + for (int i = 0; i < NETWORK_LAN_MAX_CLIENTS + 1; i++) { s_connections[i].active = false; #if defined _WINDOWS64 || defined _XBOX @@ -177,9 +190,16 @@ void NetworkSocketLayer::Shutdown() #endif { closesocket(s_connections[i].tcpSocket); + s_connections[i].tcpSocket = INVALID_SOCKET; } + if (s_connections[i].recvThread != NULL) + { + s_connections[i].recvThread->WaitForCompletion(2000); + delete s_connections[i].recvThread; + s_connections[i].recvThread = NULL; + } + DeleteCriticalSection(&s_connections[i].sendLock); } - s_connections.clear(); LeaveCriticalSection(&s_connectionsLock); if (s_acceptThread != NULL) @@ -204,6 +224,8 @@ void NetworkSocketLayer::Shutdown() DeleteCriticalSection(&s_discoveryLock); DeleteCriticalSection(&s_disconnectLock); s_disconnectedSmallIds.clear(); + DeleteCriticalSection(&s_pendingJoinLock); + s_pendingJoinSmallIds.clear(); DeleteCriticalSection(&s_freeSmallIdLock); s_freeSmallIds.clear(); s_locksCreated = false; @@ -219,6 +241,14 @@ bool NetworkSocketLayer::HostGame(int port) s_isHost = true; s_localSmallId = 0; s_hostSmallId = 0; + s_connected = false; + s_active = false; + + if (s_hostConnectionSocket != INVALID_SOCKET) + { + closesocket(s_hostConnectionSocket); + s_hostConnectionSocket = INVALID_SOCKET; + } s_nextSmallId = 1; s_hostGamePort = port; @@ -786,9 +816,9 @@ bool NetworkSocketLayer::JoinGame(const char *ip, int port) bool NetworkSocketLayer::SendOnSocket(SOCKET sock, const void *data, int dataSize) { #if defined _WINDOWS64 || defined _XBOX - if (sock == INVALID_SOCKET || dataSize <= 0) return false; + if (sock == INVALID_SOCKET || dataSize <= 0 || dataSize > NETWORK_LAN_MAX_PACKET_SIZE) return false; #elif defined __PS3__ || defined __ORBIS__ || defined __PSVITA__ - if (sock < 0 || dataSize <= 0) return false; + if (sock < 0 || dataSize <= 0 || dataSize > NETWORK_LAN_MAX_PACKET_SIZE) return false; #endif EnterCriticalSection(&s_sendLock); @@ -809,10 +839,7 @@ bool NetworkSocketLayer::SendOnSocket(SOCKET sock, const void *data, int dataSiz #elif defined __PS3__ || defined __ORBIS__ || defined __PSVITA__ if (sent < 0 || sent == 0) #endif - { - LeaveCriticalSection(&s_sendLock); return false; - } totalSent += sent; } @@ -826,14 +853,10 @@ bool NetworkSocketLayer::SendOnSocket(SOCKET sock, const void *data, int dataSiz #elif defined __PS3__ || defined __ORBIS__ || defined __PSVITA__ if (sent < 0 || sent == 0) #endif - { - LeaveCriticalSection(&s_sendLock); return false; - } totalSent += sent; } - LeaveCriticalSection(&s_sendLock); return true; } @@ -843,31 +866,38 @@ bool NetworkSocketLayer::SendToSmallId(BYTE targetSmallId, const void *data, int if (s_isHost) { - SOCKET sock = GetSocketForSmallId(targetSmallId); -#if defined _WINDOWS64 || defined _XBOX - if (sock == INVALID_SOCKET) return false; -#elif defined __PS3__ || defined __ORBIS__ || defined __PSVITA__ - if (sock < 0) return false; -#endif - return SendOnSocket(sock, data, dataSize); + EnterCriticalSection(&s_connectionsLock); + if (targetSmallId >= NETWORK_LAN_MAX_CLIENTS + 1 || !s_connections[targetSmallId].active) + { + LeaveCriticalSection(&s_connectionsLock); + return false; + } + SOCKET sock = s_connections[targetSmallId].tcpSocket; + CRITICAL_SECTION *pLock = &s_connections[targetSmallId].sendLock; + LeaveCriticalSection(&s_connectionsLock); + + EnterCriticalSection(pLock); + bool result = SendOnSocket(sock, data, dataSize); + LeaveCriticalSection(pLock); + return result; } else { - return SendOnSocket(s_hostConnectionSocket, data, dataSize); + EnterCriticalSection(&s_sendLock); + bool result = SendOnSocket(s_hostConnectionSocket, data, dataSize); + LeaveCriticalSection(&s_sendLock); + return result; } } SOCKET NetworkSocketLayer::GetSocketForSmallId(BYTE smallId) { EnterCriticalSection(&s_connectionsLock); - for (size_t i = 0; i < s_connections.size(); i++) + if (smallId < NETWORK_LAN_MAX_CLIENTS + 1 && s_connections[smallId].active) { - if (s_connections[i].smallId == smallId && s_connections[i].active) - { - SOCKET sock = s_connections[i].tcpSocket; - LeaveCriticalSection(&s_connectionsLock); - return sock; - } + SOCKET sock = s_connections[smallId].tcpSocket; + LeaveCriticalSection(&s_connectionsLock); + return sock; } LeaveCriticalSection(&s_connectionsLock); #if defined _WINDOWS64 || defined _XBOX @@ -981,15 +1011,19 @@ int NetworkSocketLayer::AcceptThreadProc(LPVOID param) continue; } - RemoteConnection conn; + RemoteConnection &conn = s_connections[assignedSmallId]; + + EnterCriticalSection(&s_connectionsLock); + + if (conn.recvThread != NULL) + { + conn.recvThread->WaitForCompletion(2000); + delete conn.recvThread; + conn.recvThread = NULL; + } conn.tcpSocket = clientSocket; conn.smallId = assignedSmallId; conn.active = true; - conn.recvThread = NULL; - - EnterCriticalSection(&s_connectionsLock); - s_connections.push_back(conn); - int connIdx = (int)s_connections.size() - 1; LeaveCriticalSection(&s_connectionsLock); app.DebugPrintf("Win64 LAN: Client connected, assigned smallId=%d\n", assignedSmallId); @@ -999,17 +1033,17 @@ int NetworkSocketLayer::AcceptThreadProc(LPVOID param) extern void Win64_SetupRemoteQNetPlayer(IQNetPlayer *player, BYTE smallId, bool isHost, bool isLocal); Win64_SetupRemoteQNetPlayer(qnetPlayer, assignedSmallId, false, false); - extern CPlatformNetworkManagerStub *g_pPlatformNetworkManager; - g_pPlatformNetworkManager->NotifyPlayerJoined(qnetPlayer); + EnterCriticalSection(&s_pendingJoinLock); + s_pendingJoinSmallIds.push_back(assignedSmallId); + LeaveCriticalSection(&s_pendingJoinLock); DWORD *threadParam = new DWORD; - *threadParam = connIdx; + *threadParam = assignedSmallId; C4JThread* hThread = new C4JThread(RecvThreadProc, threadParam, "RecvThreadProc"); hThread->Run(); EnterCriticalSection(&s_connectionsLock); - if (connIdx < (int)s_connections.size()) - s_connections[connIdx].recvThread = hThread; + s_connections[assignedSmallId].recvThread = hThread; LeaveCriticalSection(&s_connectionsLock); } return 0; @@ -1017,17 +1051,16 @@ int NetworkSocketLayer::AcceptThreadProc(LPVOID param) int NetworkSocketLayer::RecvThreadProc(LPVOID param) { - DWORD connIdx = *(DWORD *)param; + BYTE clientSmallId = (BYTE)*(DWORD *)param; delete (DWORD *)param; EnterCriticalSection(&s_connectionsLock); - if (connIdx >= (DWORD)s_connections.size()) + if (clientSmallId >= NETWORK_LAN_MAX_CLIENTS + 1 || !s_connections[clientSmallId].active) { LeaveCriticalSection(&s_connectionsLock); return 0; } - SOCKET sock = s_connections[connIdx].tcpSocket; - BYTE clientSmallId = s_connections[connIdx].smallId; + SOCKET sock = s_connections[clientSmallId].tcpSocket; LeaveCriticalSection(&s_connectionsLock); std::vector recvBuf; @@ -1048,7 +1081,7 @@ int NetworkSocketLayer::RecvThreadProc(LPVOID param) ((uint32_t)header[2] << 8) | ((uint32_t)header[3]); - if (packetSize <= 0 || packetSize > NETWORK_LAN_MAX_PACKET_SIZE) + if (packetSize <= 0 || (unsigned int)packetSize > NETWORK_LAN_MAX_PACKET_SIZE) { app.DebugPrintf("LAN: Invalid packet size %d from client smallId=%d (max=%d)\n", packetSize, @@ -1073,18 +1106,11 @@ int NetworkSocketLayer::RecvThreadProc(LPVOID param) } EnterCriticalSection(&s_connectionsLock); - for (size_t i = 0; i < s_connections.size(); i++) + s_connections[clientSmallId].active = false; + if (s_connections[clientSmallId].tcpSocket != INVALID_SOCKET) { - if (s_connections[i].smallId == clientSmallId) - { - s_connections[i].active = false; - if (s_connections[i].tcpSocket != INVALID_SOCKET) - { - closesocket(s_connections[i].tcpSocket); - s_connections[i].tcpSocket = INVALID_SOCKET; - } - break; - } + closesocket(s_connections[clientSmallId].tcpSocket); + s_connections[clientSmallId].tcpSocket = INVALID_SOCKET; } LeaveCriticalSection(&s_connectionsLock); @@ -1116,18 +1142,34 @@ void NetworkSocketLayer::PushFreeSmallId(BYTE smallId) LeaveCriticalSection(&s_freeSmallIdLock); } +bool NetworkSocketLayer::PopPendingJoinSmallId(BYTE *outSmallId) +{ + bool found = false; + EnterCriticalSection(&s_pendingJoinLock); + if (!s_pendingJoinSmallIds.empty()) + { + *outSmallId = s_pendingJoinSmallIds.back(); + s_pendingJoinSmallIds.pop_back(); + found = true; + } + LeaveCriticalSection(&s_pendingJoinLock); + return found; +} + +bool NetworkSocketLayer::IsSmallIdConnected(BYTE smallId) +{ + if (smallId >= NETWORK_LAN_MAX_CLIENTS + 1) return false; + return s_connections[smallId].active; +} + void NetworkSocketLayer::CloseConnectionBySmallId(BYTE smallId) { EnterCriticalSection(&s_connectionsLock); - for (size_t i = 0; i < s_connections.size(); i++) + if (smallId < NETWORK_LAN_MAX_CLIENTS + 1 && s_connections[smallId].active && s_connections[smallId].tcpSocket != INVALID_SOCKET) { - if (s_connections[i].smallId == smallId && s_connections[i].active && s_connections[i].tcpSocket != INVALID_SOCKET) - { - closesocket(s_connections[i].tcpSocket); - s_connections[i].tcpSocket = INVALID_SOCKET; - app.DebugPrintf("Win64 LAN: Force-closed TCP connection for smallId=%d\n", smallId); - break; - } + closesocket(s_connections[smallId].tcpSocket); + s_connections[smallId].tcpSocket = INVALID_SOCKET; + app.DebugPrintf("Win64 LAN: Force-closed TCP connection for smallId=%d\n", smallId); } LeaveCriticalSection(&s_connectionsLock); } @@ -1150,9 +1192,9 @@ int NetworkSocketLayer::ClientRecvThreadProc(LPVOID param) break; } - int packetSize = (header[0] << 24) | (header[1] << 16) | (header[2] << 8) | header[3]; + int packetSize = ((uint32_t)header[0] << 24) | ((uint32_t)header[1] << 16) | ((uint32_t)header[2] << 8) | (uint32_t)header[3]; - if (packetSize <= 0 || packetSize > NETWORK_LAN_MAX_PACKET_SIZE) + if (packetSize <= 0 || (unsigned int)packetSize > NETWORK_LAN_MAX_PACKET_SIZE) { app.DebugPrintf("LAN: Invalid packet size %d from host\n", packetSize); break; @@ -1161,7 +1203,6 @@ int NetworkSocketLayer::ClientRecvThreadProc(LPVOID param) if ((int)recvBuf.size() < packetSize) { recvBuf.resize(packetSize); - app.DebugPrintf("LAN: Resized client recv buffer to %d bytes\n", packetSize); } if (!RecvExact(s_hostConnectionSocket, &recvBuf[0], packetSize)) @@ -1494,8 +1535,8 @@ std::vector NetworkSocketLayer::GetDiscoveredSessions() int NetworkSocketLayer::DiscoveryThreadProc(LPVOID param) { - app.DebugPrintf("Discovery thread started\n"); char recvBuf[1024]; + const size_t MAX_DISCOVERED_SESSIONS = 64; while (s_discovering) { @@ -1544,6 +1585,11 @@ int NetworkSocketLayer::DiscoveryThreadProc(LPVOID param) if (broadcast->magic != NETWORK_LAN_BROADCAST_MAGIC) continue; + broadcast->hostName[31] = L'\0'; + + for (int pn = 0; pn < 8; pn++) + broadcast->playerNames[pn][XUSER_NAME_SIZE - 1] = '\0'; + char senderIP[64]; #if defined _XBOX unsigned char *ipBytes = (unsigned char *)&senderAddr.sin_addr; @@ -1586,6 +1632,12 @@ int NetworkSocketLayer::DiscoveryThreadProc(LPVOID param) if (!found) { + if (s_discoveredSessions.size() >= MAX_DISCOVERED_SESSIONS) + { + LeaveCriticalSection(&s_discoveryLock); + continue; + } + LANSession session; memset(&session, 0, sizeof(session)); strncpy(session.hostIP, senderIP, sizeof(session.hostIP) - 1); diff --git a/Minecraft.Client/Common/Network/NetworkSocketLayer.h b/Minecraft.Client/Common/Network/NetworkSocketLayer.h index 9949bdfd..ee56e7c7 100644 --- a/Minecraft.Client/Common/Network/NetworkSocketLayer.h +++ b/Minecraft.Client/Common/Network/NetworkSocketLayer.h @@ -35,7 +35,7 @@ #define NETWORK_LAN_DEFAULT_PORT 25565 #define NETWORK_LAN_MAX_CLIENTS 7 #define NETWORK_LAN_RECV_BUFFER_SIZE 65536 -#define NETWORK_LAN_MAX_PACKET_SIZE (4 * 1024 * 1024) +#define NETWORK_LAN_MAX_PACKET_SIZE (3 * 1024 * 1024) #define NETWORK_LAN_DISCOVERY_PORT 25566 #define NETWORK_LAN_BROADCAST_MAGIC 0x4D434C4E @@ -141,6 +141,7 @@ struct RemoteConnection BYTE smallId; C4JThread* recvThread; volatile bool active; + CRITICAL_SECTION sendLock; }; class NetworkSocketLayer @@ -170,6 +171,10 @@ public: static void PushFreeSmallId(BYTE smallId); static void CloseConnectionBySmallId(BYTE smallId); + static bool PopPendingJoinSmallId(BYTE *outSmallId); + + static bool IsSmallIdConnected(BYTE smallId); + static bool StartAdvertising(int gamePort, const wchar_t *hostName, unsigned int gameSettings, unsigned int texPackId, unsigned char subTexId, unsigned short netVer); static void StopAdvertising(); static void UpdateAdvertisePlayerCount(BYTE count); @@ -206,7 +211,7 @@ private: static CRITICAL_SECTION s_sendLock; static CRITICAL_SECTION s_connectionsLock; - static std::vector s_connections; + static RemoteConnection s_connections[NETWORK_LAN_MAX_CLIENTS + 1]; static SOCKET s_advertiseSock; static C4JThread* s_advertiseThread; @@ -224,6 +229,9 @@ private: static CRITICAL_SECTION s_disconnectLock; static std::vector s_disconnectedSmallIds; + static CRITICAL_SECTION s_pendingJoinLock; + static std::vector s_pendingJoinSmallIds; + static CRITICAL_SECTION s_freeSmallIdLock; static std::vector s_freeSmallIds; }; diff --git a/Minecraft.Client/Common/Network/PlatformNetworkManager.cpp b/Minecraft.Client/Common/Network/PlatformNetworkManager.cpp index 125183e4..af454b31 100644 --- a/Minecraft.Client/Common/Network/PlatformNetworkManager.cpp +++ b/Minecraft.Client/Common/Network/PlatformNetworkManager.cpp @@ -233,6 +233,8 @@ void CPlatformNetworkManagerStub::DoWork() BYTE disconnectedSmallId; while (NetworkSocketLayer::PopDisconnectedSmallId(&disconnectedSmallId)) { + if (disconnectedSmallId == 0) continue; + if (NetworkSocketLayer::IsSmallIdConnected(disconnectedSmallId)) continue; IQNetPlayer *qnetPlayer = m_pIQNet->GetPlayerBySmallId(disconnectedSmallId); if (qnetPlayer != NULL && qnetPlayer->m_smallId == disconnectedSmallId) { @@ -248,6 +250,16 @@ void CPlatformNetworkManagerStub::DoWork() } } + BYTE joinedSmallId; + while (NetworkSocketLayer::PopPendingJoinSmallId(&joinedSmallId)) + { + IQNetPlayer *qnetPlayer = m_pIQNet->GetPlayerBySmallId(joinedSmallId); + if (qnetPlayer != NULL && qnetPlayer->m_smallId == joinedSmallId) + { + NotifyPlayerJoined(qnetPlayer); + } + } + for (int i = 1; i < MINECRAFT_NET_MAX_PLAYERS; i++) { IQNetPlayer *qp = &IQNet::m_player[i]; @@ -294,12 +306,27 @@ int CPlatformNetworkManagerStub::GetLocalPlayerMask(int playerIndex) bool CPlatformNetworkManagerStub::AddLocalPlayerByUserIndex( int userIndex ) { + if (m_pIQNet->AddLocalPlayerByUserIndex(userIndex) != S_OK) return false; NotifyPlayerJoined(m_pIQNet->GetLocalPlayerByUserIndex(userIndex)); - return ( m_pIQNet->AddLocalPlayerByUserIndex(userIndex) == S_OK ); + return true; } bool CPlatformNetworkManagerStub::RemoveLocalPlayerByUserIndex( int userIndex ) { + if (userIndex > 0 && userIndex < XUSER_MAX_COUNT) + { + IQNetPlayer *qnetPlayer = m_pIQNet->GetLocalPlayerByUserIndex(userIndex); + if (qnetPlayer != NULL) + { + NotifyPlayerLeaving(qnetPlayer); + qnetPlayer->m_isRemote = true; + qnetPlayer->m_isHostPlayer = false; + qnetPlayer->m_gamertag[0] = 0; + qnetPlayer->SetCustomDataValue(0); + if (IQNet::s_playerCount > 1) + IQNet::s_playerCount--; + } + } return true; } @@ -376,7 +403,11 @@ void CPlatformNetworkManagerStub::HostGame(int localUsersMask, bool bOnlineGame, IQNet::m_player[0].m_smallId = 0; IQNet::m_player[0].m_isRemote = false; IQNet::m_player[0].m_isHostPlayer = true; +#ifdef _WINDOWS64 + extern wchar_t g_Win64UsernameW[17]; + wcscpy_s(IQNet::m_player[0].m_gamertag, 32, g_Win64UsernameW); IQNet::s_playerCount = 1; +#endif if (getNetworkPlayer(&IQNet::m_player[0]) == NULL) NotifyPlayerJoined(&IQNet::m_player[0]); @@ -854,6 +885,7 @@ bool CPlatformNetworkManagerStub::GetGameSessionInfo(int iPad, SessionID session return true; } } + return false; } void CPlatformNetworkManagerStub::SetSessionsUpdatedCallback( void (*SessionsUpdatedCallback)(LPVOID pParam), LPVOID pSearchParam ) diff --git a/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp b/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp index 9e8a6b92..9cafc1b9 100644 --- a/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_CreateWorldMenu.cpp @@ -959,11 +959,19 @@ void UIScene_CreateWorldMenu::checkStateAndStartGame() else { //ProfileManager.RequestSignInUI(false, false, false, true, false,&CScene_MultiGameCreate::StartGame_SignInReturned, this,ProfileManager.GetPrimaryPad()); +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + SignInInfo info; + info.Func = &UIScene_CreateWorldMenu::StartGame_SignInReturned; + info.lpParam = this; + info.requireOnline = m_MoreOptionsParams.bOnlineGame; + UIScene_CreateWorldMenu::StartGame_SignInReturned(this, true, ProfileManager.GetPrimaryPad()); +#else SignInInfo info; info.Func = &UIScene_CreateWorldMenu::StartGame_SignInReturned; info.lpParam = this; info.requireOnline = m_MoreOptionsParams.bOnlineGame; ui.NavigateToScene(ProfileManager.GetPrimaryPad(),eUIScene_QuadrantSignin,&info); +#endif } } else @@ -1342,12 +1350,16 @@ int UIScene_CreateWorldMenu::ConfirmCreateReturned(void *pParam,int iPad,C4JStor if(isClientSide && app.IsLocalMultiplayerAvailable()) { +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + UIScene_CreateWorldMenu::StartGame_SignInReturned(pClass, true, ProfileManager.GetPrimaryPad()); +#else //ProfileManager.RequestSignInUI(false, false, false, true, false,&UIScene_CreateWorldMenu::StartGame_SignInReturned, pClass,ProfileManager.GetPrimaryPad()); SignInInfo info; info.Func = &UIScene_CreateWorldMenu::StartGame_SignInReturned; info.lpParam = pClass; info.requireOnline = pClass->m_MoreOptionsParams.bOnlineGame; ui.NavigateToScene(ProfileManager.GetPrimaryPad(),eUIScene_QuadrantSignin,&info); +#endif } else { diff --git a/Minecraft.Client/Common/UI/UIScene_JoinMenu.cpp b/Minecraft.Client/Common/UI/UIScene_JoinMenu.cpp index f6d47048..540d396d 100644 --- a/Minecraft.Client/Common/UI/UIScene_JoinMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_JoinMenu.cpp @@ -7,7 +7,7 @@ #include "..\..\MinecraftServer.h" #include "..\..\..\Minecraft.World\net.minecraft.world.level.h" #include "..\..\..\Minecraft.World\net.minecraft.world.h" -#include "..\..\Common\Network\NetworkSocketLayer.h" +#include "..\..\Common\Network\NetworkSocketLayer.h" #define UPDATE_PLAYERS_TIMER_ID 0 #define UPDATE_PLAYERS_TIMER_TIME 30000 @@ -368,7 +368,7 @@ void UIScene_JoinMenu::checkPrivilegeCallback(LPVOID lpParam, bool hasPrivilege, void UIScene_JoinMenu::StartSharedLaunchFlow() { - const bool bManualJoin = (g_MultiplayerJoin == true); + const bool bManualJoin = (g_MultiplayerJoin == true); if (bManualJoin) { JoinGame(this); @@ -431,7 +431,7 @@ void UIScene_JoinMenu::JoinGame(UIScene_JoinMenu* pClass) { return; } - const bool bManualJoin = (g_MultiplayerJoin == true); + const bool bManualJoin = (g_MultiplayerJoin == true); DWORD dwSignedInUsers = 0; bool noPrivileges = false; diff --git a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp index 7c7eda77..47fe593c 100644 --- a/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_LoadMenu.cpp @@ -1446,7 +1446,12 @@ int UIScene_LoadMenu::LoadDataComplete(void *pParam) #endif else { +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + DWORD dwLocalUsersMask = CGameNetworkManager::GetLocalPlayerMask(ProfileManager.GetPrimaryPad()); + StartGameFromSave(pClass, dwLocalUsersMask); +#else pClass->m_bRequestQuadrantSignin = true; +#endif } } } diff --git a/Minecraft.Client/Common/UI/UIScene_MainMenu.cpp b/Minecraft.Client/Common/UI/UIScene_MainMenu.cpp index 1a6f51d5..4d1a97f4 100644 --- a/Minecraft.Client/Common/UI/UIScene_MainMenu.cpp +++ b/Minecraft.Client/Common/UI/UIScene_MainMenu.cpp @@ -8,7 +8,7 @@ #include "UIScene_MainMenu.h" #ifdef __ORBIS__ #include -#include "..\..\Common\Network\NetworkSocketLayer.h" +#include "..\..\Common\Network\NetworkSocketLayer.h" #endif Random *UIScene_MainMenu::random = new Random(); @@ -319,7 +319,7 @@ void UIScene_MainMenu::handlePress(F64 controlId, F64 childId) //CD - Added for audio ui.PlayUISFX(eSFX_Press); - if(g_MultiplayerJoin) + if(g_MultiplayerJoin) { // request only completes after the platform network timeout. // this needs to be done before hand or else the PS4 crashes ill need to look more into this @@ -386,6 +386,10 @@ void UIScene_MainMenu::handlePress(F64 controlId, F64 childId) ui.NavigateToScene(primaryPad,eUIScene_TrialExitUpsell); } break; +#elif defined _WINDOWS64 + case eControl_Exit: + app.ExitGame(); + break; #endif #ifdef _DURANGO @@ -1108,7 +1112,7 @@ void UIScene_MainMenu::RefreshChatAndContentRestrictionsReturned_PlayGame(void * int primaryPad = ProfileManager.GetPrimaryPad(); UIScene_MainMenu* pClass = (UIScene_MainMenu*)pParam; - const bool bManualJoin = (g_MultiplayerJoin == true); + const bool bManualJoin = (g_MultiplayerJoin == true); if (bManualJoin) { CreateLoad_SignInReturned(pClass, true, primaryPad); diff --git a/Minecraft.Client/Extrax64Stubs.cpp b/Minecraft.Client/Extrax64Stubs.cpp index 299639c4..4c605e7f 100644 --- a/Minecraft.Client/Extrax64Stubs.cpp +++ b/Minecraft.Client/Extrax64Stubs.cpp @@ -355,7 +355,7 @@ DWORD XEnableGuestSignin(BOOL fEnable) { return 0; } /////////////////////////////////////////////// Profile library #ifdef _WINDOWS64 static void *profileData[4]; -static bool s_bProfileIsFullVersion; +static bool s_bProfileIsFullVersion = true; void C_4JProfile::Initialise( DWORD dwTitleID, DWORD dwOfferID, unsigned short usProfileVersion, @@ -374,6 +374,7 @@ void C_4JProfile::Initialise( DWORD dwTitleID, GAME_SETTINGS *pGameSettings = (GAME_SETTINGS *)profileData[i]; pGameSettings->ucMenuSensitivity=100; //eGameSetting_Sensitivity_InMenu pGameSettings->ucInterfaceOpacity=80; //eGameSetting_Sensitivity_InMenu + pGameSettings->ucGamma=100; //eGameSetting_Gamma pGameSettings->usBitmaskValues|=0x0200; //eGameSetting_DisplaySplitscreenGamertags - on pGameSettings->usBitmaskValues|=0x0400; //eGameSetting_Hints - on pGameSettings->usBitmaskValues|=0x1000; //eGameSetting_Autosave - 2 @@ -437,7 +438,95 @@ DWORD IQNetPlayer::GetCurrentRtt() { return 0; } bool IQNetPlayer::IsHost() { return m_isHostPlayer; } bool IQNetPlayer::IsGuest() { return false; } bool IQNetPlayer::IsLocal() { return !m_isRemote; } -PlayerUID IQNetPlayer::GetXuid() { return (PlayerUID)(0xe000d45248242f2e + m_smallId); } +static void Win64_BuildSplitName(int iPad, char *outName, int outSize); + +PlayerUID IQNetPlayer::GetXuid() +{ +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + if (!m_isRemote) + { + int idx = (int)(this - &IQNet::m_player[0]); + if (idx == 0) + { + extern char g_Win64Username[17]; + return Win64_UsernameToXuid(g_Win64Username); + } + if (idx > 0 && idx < XUSER_MAX_COUNT) + { + char splitName[32]; + Win64_BuildSplitName(idx, splitName, sizeof(splitName)); + return Win64_UsernameToXuid(splitName); + } + } +#endif + return (PlayerUID)(0xe000d45248242f2e + m_smallId); +} + +PlayerUID Win64_UsernameToXuid(const char* username) +{ + uint64_t hash = 14695981039346656037ULL; + for (const char* p = username; *p; ++p) + { + hash ^= (uint64_t)(unsigned char)(*p); + hash *= 1099511628211ULL; + } + + const uint64_t WIN64_XUID_BASE = 0xe000d45248242f2e; + if (hash >= WIN64_XUID_BASE && hash <= WIN64_XUID_BASE + MINECRAFT_NET_MAX_PLAYERS) + hash = WIN64_XUID_BASE + MINECRAFT_NET_MAX_PLAYERS + 1; + if (hash == 0) + hash = 1; + return (PlayerUID)hash; +} + +PlayerUID Win64_UsernameToXuid(const wchar_t* username) +{ + char narrow[64]; + int i = 0; + for (; username[i] && i < 63; ++i) + narrow[i] = (char)(unsigned char)(username[i] & 0xFF); + narrow[i] = 0; + return Win64_UsernameToXuid(narrow); +} + +static void Win64_BuildSplitName(int iPad, char *outName, int outSize) +{ + extern char g_Win64Username[17]; + char candidate[32]; + sprintf(candidate, "%s_%d", g_Win64Username, iPad); + for (DWORD i = 0; i < MINECRAFT_NET_MAX_PLAYERS; i++) + { + if (!IQNet::m_player[i].m_isRemote) continue; + if (IQNet::m_player[i].m_gamertag[0] == 0) continue; + char remoteName[64]; + int j = 0; + for (; IQNet::m_player[i].m_gamertag[j] && j < 63; ++j) + remoteName[j] = (char)(unsigned char)(IQNet::m_player[i].m_gamertag[j] & 0xFF); + remoteName[j] = 0; +#if defined(_MSC_VER) + if (_stricmp(candidate, remoteName) == 0) +#else + if (strcasecmp(candidate, remoteName) == 0) +#endif + { + sprintf(candidate, "%s_%d_L", g_Win64Username, iPad); + break; + } + } + strncpy(outName, candidate, outSize - 1); + outName[outSize - 1] = 0; +} + +static void Win64_BuildSplitNameW(int iPad, wchar_t *outName, int outSize) +{ + char narrow[32]; + Win64_BuildSplitName(iPad, narrow, sizeof(narrow)); + for (int i = 0; i < outSize - 1 && narrow[i]; ++i) + { + outName[i] = (wchar_t)(unsigned char)narrow[i]; + outName[i + 1] = 0; + } +} LPCWSTR IQNetPlayer::GetGamertag() { return m_gamertag; } int IQNetPlayer::GetSessionIndex() { return m_smallId; } bool IQNetPlayer::IsTalking() { return false; } @@ -470,15 +559,30 @@ void Win64_SetupRemoteQNetPlayer(IQNetPlayer *player, BYTE smallId, bool isHost, static bool Win64_IsActivePlayer(IQNetPlayer *p, DWORD index); -HRESULT IQNet::AddLocalPlayerByUserIndex(DWORD dwUserIndex){ return S_OK; } +HRESULT IQNet::AddLocalPlayerByUserIndex(DWORD dwUserIndex) +{ + // no E_FAIL on PS3. + if (dwUserIndex >= MINECRAFT_NET_MAX_PLAYERS) return (HRESULT)0x80004005L; + m_player[dwUserIndex].m_isRemote = false; + m_player[dwUserIndex].m_smallId = (BYTE)dwUserIndex; + if (dwUserIndex > 0) + { + wchar_t splitNameW[32]; + Win64_BuildSplitNameW((int)dwUserIndex, splitNameW, 32); + wcsncpy(m_player[dwUserIndex].m_gamertag, splitNameW, 32 - 1); + m_player[dwUserIndex].m_gamertag[32 - 1] = 0; + } + if (dwUserIndex >= (DWORD)s_playerCount) + s_playerCount = dwUserIndex + 1; + return S_OK; +} IQNetPlayer *IQNet::GetHostPlayer() { return &m_player[0]; } IQNetPlayer *IQNet::GetLocalPlayerByUserIndex(DWORD dwUserIndex) { if (s_isHosting) { if (dwUserIndex < MINECRAFT_NET_MAX_PLAYERS && - !m_player[dwUserIndex].m_isRemote && - Win64_IsActivePlayer(&m_player[dwUserIndex], dwUserIndex)) + !m_player[dwUserIndex].m_isRemote) return &m_player[dwUserIndex]; return NULL; } @@ -575,7 +679,7 @@ void C_4JProfile::SetTrialTextStringTable(CXuiStringTable *pStringTable,int i void C_4JProfile::SetTrialAwardText(eAwardType AwardType,int iTitle,int iText) {} int C_4JProfile::GetLockedProfile() { return 0; } void C_4JProfile::SetLockedProfile(int iProf) {} -bool C_4JProfile::IsSignedIn(int iQuadrant) { return ( iQuadrant == 0); } +bool C_4JProfile::IsSignedIn(int iQuadrant) { return (iQuadrant >= 0 && iQuadrant < XUSER_MAX_COUNT); } bool C_4JProfile::IsSignedInLive(int iProf) { return true; } bool C_4JProfile::IsGuest(int iQuadrant) { return false; } UINT C_4JProfile::RequestSignInUI(bool bFromInvite,bool bLocalGame,bool bNoGuestsAllowed,bool bMultiplayerSignIn,bool bAddUser, int( *Func)(LPVOID,const bool, const int iPad),LPVOID lpParam,int iQuadrant) { return 0; } @@ -585,16 +689,21 @@ void C_4JProfile::SetPrimaryPlayerChanged(bool bVal) {} bool C_4JProfile::QuerySigninStatus(void) { return true; } void C_4JProfile::GetXUID(int iPad, PlayerUID *pXuid,bool bOnlineXuid) { - if (iPad != 0) + if (iPad == 0) { - // previously INVALID_XUID - *pXuid = 0; - return; + extern char g_Win64Username[17]; + *pXuid = Win64_UsernameToXuid(g_Win64Username); + } + else if (iPad > 0 && iPad < XUSER_MAX_COUNT) + { + char splitName[32]; + Win64_BuildSplitName(iPad, splitName, sizeof(splitName)); + *pXuid = Win64_UsernameToXuid(splitName); } - if (IQNet::s_isHosting) - *pXuid = 0xe000d45248242f2e; else - *pXuid = 0xe000d45248242f2e + NetworkSocketLayer::GetLocalSmallId(); + { + *pXuid = INVALID_XUID; + } } BOOL C_4JProfile::AreXUIDSEqual(PlayerUID xuid1,PlayerUID xuid2) { return xuid1 == xuid2; } BOOL C_4JProfile::XUIDIsGuest(PlayerUID xuid) { return false; } @@ -623,8 +732,30 @@ char fakeGamerTag[32] = "PlayerName"; void SetFakeGamertag(char *name){ strcpy_s(fakeGamerTag, name); } char* C_4JProfile::GetGamertag(int iPad){ return fakeGamerTag; } #else -char* C_4JProfile::GetGamertag(int iPad){ extern char g_Win64Username[17]; return g_Win64Username; } -wstring C_4JProfile::GetDisplayName(int iPad){ extern wchar_t g_Win64UsernameW[17]; return g_Win64UsernameW; } +static char s_win64SplitNames[4][32]; +char* C_4JProfile::GetGamertag(int iPad) +{ + extern char g_Win64Username[17]; + if (iPad == 0) return g_Win64Username; + if (iPad > 0 && iPad < XUSER_MAX_COUNT) + { + Win64_BuildSplitName(iPad, s_win64SplitNames[iPad], sizeof(s_win64SplitNames[iPad])); + return s_win64SplitNames[iPad]; + } + return g_Win64Username; +} +wstring C_4JProfile::GetDisplayName(int iPad) +{ + extern wchar_t g_Win64UsernameW[17]; + if (iPad == 0) return g_Win64UsernameW; + if (iPad > 0 && iPad < XUSER_MAX_COUNT) + { + wchar_t buf[32]; + Win64_BuildSplitNameW(iPad, buf, 32); + return buf; + } + return g_Win64UsernameW; +} #endif bool C_4JProfile::IsFullVersion() { return s_bProfileIsFullVersion; } void C_4JProfile::SetSignInChangeCallback(void ( *Func)(LPVOID, bool, unsigned int),LPVOID lpParam) {} diff --git a/Minecraft.Client/LevelRenderer.cpp b/Minecraft.Client/LevelRenderer.cpp index 8947b759..6e883ccc 100644 --- a/Minecraft.Client/LevelRenderer.cpp +++ b/Minecraft.Client/LevelRenderer.cpp @@ -1964,7 +1964,11 @@ bool LevelRenderer::updateDirtyChunks() { if( (!onlyRebuild) || globalChunkFlags[ pClipChunk->globalIdx ] & CHUNK_FLAG_COMPILED || +#ifdef _WINDOWS64 + ( distSq < 96 * 96 ) ) // Always rebuild really near things or else building (say) at tower up into empty blocks when we are low on memory will not create render data +#else ( distSq < 20 * 20 ) ) // Always rebuild really near things or else building (say) at tower up into empty blocks when we are low on memory will not create render data +#endif { considered++; // Is this chunk nearer than our nearest? diff --git a/Minecraft.Client/LevelRenderer.h b/Minecraft.Client/LevelRenderer.h index bd3af8c8..a3da5426 100644 --- a/Minecraft.Client/LevelRenderer.h +++ b/Minecraft.Client/LevelRenderer.h @@ -52,7 +52,9 @@ public: static const int CHUNK_SIZE = 16; #endif static const int CHUNK_Y_COUNT = Level::maxBuildHeight / CHUNK_SIZE; -#if ( defined _XBOX_ONE || defined _WINDOWS64 ) +#if defined _WINDOWS64 + static const int MAX_COMMANDBUFFER_ALLOCATIONS = 2047 * 1024 * 1024; // whisper - added (wow) +#elif ( defined _XBOX_ONE ) static const int MAX_COMMANDBUFFER_ALLOCATIONS = 512 * 1024 * 1024; // 4J - added #elif defined __ORBIS__ static const int MAX_COMMANDBUFFER_ALLOCATIONS = 448 * 1024 * 1024; // 4J - added - hard limit is 512 so giving a lot of headroom here for fragmentation (have seen 16MB lost to fragmentation in multiplayer crash dump before) diff --git a/Minecraft.Client/MinecraftServer.h b/Minecraft.Client/MinecraftServer.h index 53417bb1..fb2a8640 100644 --- a/Minecraft.Client/MinecraftServer.h +++ b/Minecraft.Client/MinecraftServer.h @@ -236,7 +236,7 @@ public: static void SetTime(__int64 time) { setTimeAtEndOfTick = true; setTime = time; } C4JThread::Event* m_serverPausedEvent; -private: +public: // 4J Added bool m_isServerPaused; diff --git a/Minecraft.Client/MultiPlayerGameMode.cpp b/Minecraft.Client/MultiPlayerGameMode.cpp index bd99a9e6..5bc0fc8a 100644 --- a/Minecraft.Client/MultiPlayerGameMode.cpp +++ b/Minecraft.Client/MultiPlayerGameMode.cpp @@ -85,6 +85,20 @@ bool MultiPlayerGameMode::destroyBlock(int x, int y, int z, int face) if (oldTile == NULL) return false; +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + if (g_NetworkManager.IsHost()) + { + level->levelEvent(LevelEvent::PARTICLES_DESTROY_BLOCK, x, y, z, oldTile->id + (level->getData(x, y, z) << Tile::TILE_NUM_SHIFT)); + int data = level->getData(x, y, z); + bool changed = level->removeTile(x, y, z); + if (changed) + { + oldTile->destroy(level, x, y, z, data); + } + return changed; + } +#endif + level->levelEvent(LevelEvent::PARTICLES_DESTROY_BLOCK, x, y, z, oldTile->id + (level->getData(x, y, z) << Tile::TILE_NUM_SHIFT)); int data = level->getData(x, y, z); diff --git a/Minecraft.Client/Orbis/Orbis_Minecraft.cpp b/Minecraft.Client/Orbis/Orbis_Minecraft.cpp index a0d342b7..6c7e1c4c 100644 --- a/Minecraft.Client/Orbis/Orbis_Minecraft.cpp +++ b/Minecraft.Client/Orbis/Orbis_Minecraft.cpp @@ -80,6 +80,8 @@ DWORD dwProfileSettingsA[NUM_PROFILE_VALUES]= uint8_t * AddRichPresenceString(int iID); void FreeRichPresenceStrings(); +char g_Win64Username[17] = {0}; + BOOL g_bWidescreen = TRUE; @@ -984,6 +986,9 @@ int main(int argc, const char *argv[] ) app.GAME_DEFINED_PROFILE_DATA_BYTES*XUSER_MAX_COUNT, &app.uiGameDefinedDataChangedBitmask); + strncpy(g_Win64Username, ProfileManager.GetGamertag(0), 17); + g_Win64Username[16] = 0; + // register the awards RegisterAwardsWithProfileManager(); diff --git a/Minecraft.Client/PS3/PS3_Minecraft.cpp b/Minecraft.Client/PS3/PS3_Minecraft.cpp index cf47bbb7..27812042 100644 --- a/Minecraft.Client/PS3/PS3_Minecraft.cpp +++ b/Minecraft.Client/PS3/PS3_Minecraft.cpp @@ -158,6 +158,8 @@ extern "C" void* __wrap__malloc_init(size_t a_Boundary, size_t a_Size) // for a long time. //------------------------------------------------------------------------------------- +char g_Win64Username[17] = {0}; + BOOL g_bWidescreen = TRUE; //int g_numberOfSpeakersForMiles = 2; // number of speakers to pass to Miles, this is setup from init_audio_hardware @@ -910,6 +912,9 @@ int main() app.GAME_DEFINED_PROFILE_DATA_BYTES*XUSER_MAX_COUNT, &app.uiGameDefinedDataChangedBitmask); + strncpy(g_Win64Username, ProfileManager.GetGamertag(0), 17); + g_Win64Username[16] = 0; + app.DebugPrintf("+++Main - after ProfileManager.Initialise\n"); // register the awards diff --git a/Minecraft.Client/PSVita/PSVita_Minecraft.cpp b/Minecraft.Client/PSVita/PSVita_Minecraft.cpp index ea26eb59..4301a9f0 100644 --- a/Minecraft.Client/PSVita/PSVita_Minecraft.cpp +++ b/Minecraft.Client/PSVita/PSVita_Minecraft.cpp @@ -133,6 +133,8 @@ extern "C" void* __wrap__malloc_init(size_t a_Boundary, size_t a_Size) // for a long time. //------------------------------------------------------------------------------------- +char g_Win64Username[17] = {0}; + BOOL g_bWidescreen = TRUE; //int g_numberOfSpeakersForMiles = 2; // number of speakers to pass to Miles, this is setup from init_audio_hardware @@ -601,6 +603,8 @@ int main() app.GAME_DEFINED_PROFILE_DATA_BYTES*XUSER_MAX_COUNT, &app.uiGameDefinedDataChangedBitmask); + strncpy(g_Win64Username, ProfileManager.GetGamertag(0), 17); + g_Win64Username[16] = 0; // register the awards RegisterAwardsWithProfileManager(); diff --git a/Minecraft.Client/PlayerChunkMap.cpp b/Minecraft.Client/PlayerChunkMap.cpp index bc5f8fc5..fe9c49ff 100644 --- a/Minecraft.Client/PlayerChunkMap.cpp +++ b/Minecraft.Client/PlayerChunkMap.cpp @@ -539,7 +539,12 @@ void PlayerChunkMap::getChunkAndRemovePlayer(int x, int z, shared_ptr player) { - if( addRequests.size() ) +#ifdef _WINDOWS64 + const int maxPerTick = 10; +#else + const int maxPerTick = 1; +#endif + for (int _processed = 0; _processed < maxPerTick && addRequests.size(); _processed++) { // Find the nearest chunk request to the player int px = (int)player->x; @@ -569,6 +574,10 @@ void PlayerChunkMap::tickAddRequests(shared_ptr player) getChunk(itNearest->x, itNearest->z, true)->add(itNearest->player); addRequests.erase(itNearest); } + else + { + break; + } } } diff --git a/Minecraft.Client/PlayerConnection.cpp b/Minecraft.Client/PlayerConnection.cpp index 2658f8e3..9b5312d8 100644 --- a/Minecraft.Client/PlayerConnection.cpp +++ b/Minecraft.Client/PlayerConnection.cpp @@ -1577,7 +1577,10 @@ bool PlayerConnection::isDisconnected() void PlayerConnection::handleDebugOptions(shared_ptr packet) { //Player player = dynamic_pointer_cast( player->shared_from_this() ); - player->SetDebugOptions(packet->m_uiVal); + if(app.DebugSettingsOn()) + { + player->SetDebugOptions(packet->m_uiVal); + } } void PlayerConnection::handleCraftItem(shared_ptr packet) @@ -1587,6 +1590,10 @@ void PlayerConnection::handleCraftItem(shared_ptr packet) if(iRecipe == -1) return; + int recipeCount = (int)Recipes::getInstance()->getRecipies()->size(); + if(iRecipe < 0 || iRecipe >= recipeCount) + return; + Recipy::INGREDIENTS_REQUIRED *pRecipeIngredientsRequired=Recipes::getInstance()->getRecipeIngredientsArray(); shared_ptr pTempItemInst=pRecipeIngredientsRequired[iRecipe].pRecipy->assemble(nullptr); diff --git a/Minecraft.Client/ServerLevel.cpp b/Minecraft.Client/ServerLevel.cpp index bb78fe3b..1150c78b 100644 --- a/Minecraft.Client/ServerLevel.cpp +++ b/Minecraft.Client/ServerLevel.cpp @@ -1086,7 +1086,9 @@ void ServerLevel::entityRemoved(shared_ptr e) shared_ptr ServerLevel::getEntity(int id) { - return entitiesById[id]; + AUTO_VAR(it, entitiesById.find(id)); + if(it != entitiesById.end()) return it->second; + return nullptr; } bool ServerLevel::addGlobalEntity(shared_ptr e) diff --git a/Minecraft.Client/ServerPlayer.cpp b/Minecraft.Client/ServerPlayer.cpp index ec30e2d8..7a441eb7 100644 --- a/Minecraft.Client/ServerPlayer.cpp +++ b/Minecraft.Client/ServerPlayer.cpp @@ -329,6 +329,10 @@ void ServerPlayer::doTickA() // 4J - split off the chunk sending bit of the tick here from ::doTick so we can do this exactly once per player per server tick void ServerPlayer::doChunkSendingTick(bool dontDelayChunks) { +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + for (int _w64cs = 0; _w64cs < 4; _w64cs++) + { +#endif // printf("[%d] %s: sendChunks: %d, empty: %d\n",tickCount, connection->getNetworkPlayer()->GetUID().getOnlineID(),sendChunks,chunksToSend.empty()); if (!chunksToSend.empty()) { @@ -367,6 +371,17 @@ void ServerPlayer::doChunkSendingTick(bool dontDelayChunks) } else { +#if defined(_WINDOWS64) + if( dontDelayChunks || + ((connection->countDelayedPackets() < 16 )&& + (g_NetworkManager.GetHostPlayer()->GetSendQueueSizeMessages( NULL, true ) < 16 )&& + !connection->done) ) + { + lastBrupSendTickCount = tickCount; + okToSend = true; + MinecraftServer::s_slowQueuePacketSent = true; + } +#else bool canSendToPlayer = MinecraftServer::chunkPacketManagement_CanSendTo(connection->getNetworkPlayer()); // app.DebugPrintf(">>> %d\n", canSendToPlayer); @@ -408,6 +423,7 @@ void ServerPlayer::doChunkSendingTick(bool dontDelayChunks) { // app.DebugPrintf(" - \n"); } +#endif } if (okToSend) @@ -485,6 +501,9 @@ void ServerPlayer::doChunkSendingTick(bool dontDelayChunks) } } } +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + } +#endif } void ServerPlayer::doTickB() diff --git a/Minecraft.Client/Xbox/Xbox_Minecraft.cpp b/Minecraft.Client/Xbox/Xbox_Minecraft.cpp index 30c88dc9..f7489850 100644 --- a/Minecraft.Client/Xbox/Xbox_Minecraft.cpp +++ b/Minecraft.Client/Xbox/Xbox_Minecraft.cpp @@ -94,6 +94,8 @@ D3DSAMPLERSTATETYPE SamplerStateModes[]= //------------------------------------------------------------------------------------- +char g_Win64Username[17] = {0}; + BOOL g_bWidescreen = TRUE; @@ -433,6 +435,9 @@ int __cdecl main() &app.uiGameDefinedDataChangedBitmask ); + strncpy(g_Win64Username, ProfileManager.GetGamertag(0), 17); + g_Win64Username[16] = 0; + // register the awards ProfileManager.RegisterAward(eAward_TakingInventory, ACHIEVEMENT_01, eAwardType_Achievement); ProfileManager.RegisterAward(eAward_GettingWood, ACHIEVEMENT_02, eAwardType_Achievement); diff --git a/Minecraft.World/AwardStatPacket.cpp b/Minecraft.World/AwardStatPacket.cpp index b1e3d9e4..6e856a53 100644 --- a/Minecraft.World/AwardStatPacket.cpp +++ b/Minecraft.World/AwardStatPacket.cpp @@ -47,7 +47,7 @@ void AwardStatPacket::read(DataInputStream *dis) //throws IOException // Read parameter blob. int length = dis->readInt(); - if(length > 0) + if(length > 0 && length <= 65536) { m_paramData = byteArray(length); dis->readFully(m_paramData); diff --git a/Minecraft.World/BlockRegionUpdatePacket.cpp b/Minecraft.World/BlockRegionUpdatePacket.cpp index d5484e5a..52ca2255 100644 --- a/Minecraft.World/BlockRegionUpdatePacket.cpp +++ b/Minecraft.World/BlockRegionUpdatePacket.cpp @@ -103,6 +103,12 @@ void BlockRegionUpdatePacket::read(DataInputStream *dis) //throws IOException levelIdx = ( size >> 30 ) & 3; size &= 0x3fffffff; + const int MAX_COMPRESSED_CHUNK_SIZE = 5 * 1024 * 1024; + if(size < 0 || size > MAX_COMPRESSED_CHUNK_SIZE) + { + size = 0; + } + if(size == 0) { buffer = byteArray(); @@ -131,7 +137,10 @@ void BlockRegionUpdatePacket::read(DataInputStream *dis) //throws IOException delete [] compressedBuffer.data; - assert(buffer.length == outputSize); + if(buffer.length != outputSize) + { + app.DebugPrintf("BlockRegionUpdatePacket: decompressed size mismatch (expected %d, got %d)\n", buffer.length, outputSize); + } } } diff --git a/Minecraft.World/ByteArrayInputStream.cpp b/Minecraft.World/ByteArrayInputStream.cpp index 3fd24933..630013b3 100644 --- a/Minecraft.World/ByteArrayInputStream.cpp +++ b/Minecraft.World/ByteArrayInputStream.cpp @@ -10,8 +10,14 @@ //offset - the offset in the buffer of the first byte to read. //length - the maximum number of bytes to read from the buffer. ByteArrayInputStream::ByteArrayInputStream(byteArray buf, unsigned int offset, unsigned int length) - : pos( offset ), count( min( offset+length, buf.length ) ), mark( offset ) + : pos( offset ), mark( offset ) { + if( offset > buf.length ) + count = buf.length; + else if( length > buf.length - offset ) + count = buf.length; + else + count = offset + length; this->buf = buf; } diff --git a/Minecraft.World/ByteArrayOutputStream.cpp b/Minecraft.World/ByteArrayOutputStream.cpp index 5d971031..53125e21 100644 --- a/Minecraft.World/ByteArrayOutputStream.cpp +++ b/Minecraft.World/ByteArrayOutputStream.cpp @@ -31,7 +31,12 @@ void ByteArrayOutputStream::write(unsigned int b) { // If we will fill the buffer we need to make it bigger if( count + 1 >= buf.length ) - buf.resize( buf.length * 2 ); + { + unsigned int newSize = buf.length * 2; + if( newSize <= buf.length ) + return; + buf.resize( newSize ); + } buf[count] = (byte) b; count++; diff --git a/Minecraft.World/ByteArrayTag.h b/Minecraft.World/ByteArrayTag.h index 7ecc88f4..9d2eae31 100644 --- a/Minecraft.World/ByteArrayTag.h +++ b/Minecraft.World/ByteArrayTag.h @@ -21,6 +21,8 @@ public: void load(DataInput *dis, int tagDepth) { int length = dis->readInt(); + + if (length < 0 || length > 2 * 1024 * 1024) length = 0; if ( data.data ) delete[] data.data; data = byteArray(length); diff --git a/Minecraft.World/ComplexItemDataPacket.cpp b/Minecraft.World/ComplexItemDataPacket.cpp index fdb6e122..ccebc4f5 100644 --- a/Minecraft.World/ComplexItemDataPacket.cpp +++ b/Minecraft.World/ComplexItemDataPacket.cpp @@ -32,7 +32,9 @@ void ComplexItemDataPacket::read(DataInputStream *dis) //throws IOException itemType = dis->readShort(); itemId = dis->readShort(); - data = charArray(dis->readUnsignedShort() & 0xffff); + int dataLength = dis->readUnsignedShort() & 0xffff; + if(dataLength > 32767) dataLength = 0; + data = charArray(dataLength); dis->readFully(data); } diff --git a/Minecraft.World/CompoundTag.h b/Minecraft.World/CompoundTag.h index 3e2dcd1f..313e6830 100644 --- a/Minecraft.World/CompoundTag.h +++ b/Minecraft.World/CompoundTag.h @@ -43,9 +43,12 @@ public: } tags.clear(); Tag *tag; + int tagCount = 0; + const int MAX_COMPOUND_TAGS = 10000; while ((tag = Tag::readNamedTag(dis))->getId() != Tag::TAG_End) { tags[tag->getName()] = tag; + if(++tagCount >= MAX_COMPOUND_TAGS) break; } delete tag; } diff --git a/Minecraft.World/Connection.cpp b/Minecraft.World/Connection.cpp index d3fb5694..bb4e1477 100644 --- a/Minecraft.World/Connection.cpp +++ b/Minecraft.World/Connection.cpp @@ -108,8 +108,8 @@ Connection::Connection(Socket *socket, const wstring& id, PacketListener *packet const char *szId = wstringtofilename(id); char readThreadName[256]; char writeThreadName[256]; - sprintf(readThreadName,"%s read\n",szId); - sprintf(writeThreadName,"%s write\n",szId); + sprintf(readThreadName, "%.240s read\n", szId); + sprintf(writeThreadName, "%.240s write\n", szId); readThread = new C4JThread(runRead, (void*)this, readThreadName, READ_STACK_SIZE); writeThread = new C4JThread(runWrite, this, writeThreadName, WRITE_STACK_SIZE); diff --git a/Minecraft.World/ContainerSetContentPacket.cpp b/Minecraft.World/ContainerSetContentPacket.cpp index 9fb2df06..fd2ab8c5 100644 --- a/Minecraft.World/ContainerSetContentPacket.cpp +++ b/Minecraft.World/ContainerSetContentPacket.cpp @@ -32,6 +32,9 @@ void ContainerSetContentPacket::read(DataInputStream *dis) //throws IOException { containerId = dis->readByte(); int count = dis->readShort(); + + if(count < 0 || count > 256) count = 0; + items = ItemInstanceArray(count); for (int i = 0; i < count; i++) { diff --git a/Minecraft.World/ContainerSetSlotPacket.cpp b/Minecraft.World/ContainerSetSlotPacket.cpp index 39b25112..da98a8dc 100644 --- a/Minecraft.World/ContainerSetSlotPacket.cpp +++ b/Minecraft.World/ContainerSetSlotPacket.cpp @@ -35,7 +35,7 @@ void ContainerSetSlotPacket::read(DataInputStream *dis) //throws IOException // 4J Stu - TU-1 hotfix // Fix for #13142 - Holding down the A button on the furnace ingredient slot causes the UI to display incorrect item counts BYTE byteId = dis->readByte(); - containerId = *(char *)&byteId; + containerId = (char)(signed char)byteId; slot = dis->readShort(); item = readItem(dis); } diff --git a/Minecraft.World/CustomPayloadPacket.cpp b/Minecraft.World/CustomPayloadPacket.cpp index 7d108d11..43c213eb 100644 --- a/Minecraft.World/CustomPayloadPacket.cpp +++ b/Minecraft.World/CustomPayloadPacket.cpp @@ -43,7 +43,7 @@ void CustomPayloadPacket::read(DataInputStream *dis) identifier = readUtf(dis, 20); length = dis->readShort(); - if (length > 0 && length < Short::MAX_VALUE) + if (length > 0 && length <= Short::MAX_VALUE) { if(data.data != NULL) { diff --git a/Minecraft.World/DataInputStream.cpp b/Minecraft.World/DataInputStream.cpp index 9bf61c76..ab82a265 100644 --- a/Minecraft.World/DataInputStream.cpp +++ b/Minecraft.World/DataInputStream.cpp @@ -303,6 +303,10 @@ wstring DataInputStream::readUTF() int b = stream->read(); unsigned short UTFLength = (unsigned short) (((a & 0xff) << 8) | (b & 0xff)); + const unsigned short MAX_UTF_LENGTH = 32767; + if( UTFLength > MAX_UTF_LENGTH ) + return outputString; + //// 4J Stu - I decided while writing DataOutputStream that we didn't need to bother using the UTF8 format //// used in the java libs, and just write in/out as wchar_t all the time diff --git a/Minecraft.World/DirectoryLevelStorage.cpp b/Minecraft.World/DirectoryLevelStorage.cpp index d6def6f9..d939f89f 100644 --- a/Minecraft.World/DirectoryLevelStorage.cpp +++ b/Minecraft.World/DirectoryLevelStorage.cpp @@ -432,6 +432,28 @@ void DirectoryLevelStorage::save(shared_ptr player) CompoundTag *DirectoryLevelStorage::load(shared_ptr player) { CompoundTag *tag = loadPlayerDataTag( player->getXuid() ); + +#if defined(_WINDOWS64) || defined(DISABLE_PSN) || defined(_DISABLE_XBLIVE) + if (tag == NULL) + { + const PlayerUID WIN64_XUID_BASE = (PlayerUID)0xe000d45248242f2e; + for (int i = 0; i < MINECRAFT_NET_MAX_PLAYERS; i++) + { + PlayerUID oldXuid = WIN64_XUID_BASE + i; + tag = loadPlayerDataTag(oldXuid); + if (tag != NULL) + { + ConsoleSavePath oldFile = ConsoleSavePath(playerDir.getName() + _toString(oldXuid) + L".dat"); + if (m_saveFile->doesFileExist(oldFile)) + { + m_saveFile->deleteFile(m_saveFile->createFile(oldFile)); + } + app.DebugPrintf("Migrated player data from old XUID %llu to new XUID %llu\n", oldXuid, player->getXuid()); + break; + } + } + } +#endif if (tag != NULL) { player->load(tag); diff --git a/Minecraft.World/ExplodePacket.cpp b/Minecraft.World/ExplodePacket.cpp index edcd755c..1b87d1d8 100644 --- a/Minecraft.World/ExplodePacket.cpp +++ b/Minecraft.World/ExplodePacket.cpp @@ -56,6 +56,8 @@ void ExplodePacket::read(DataInputStream *dis) //throws IOException r = dis->readFloat(); int count = dis->readInt(); + if(count < 0 || count > 32768) count = 0; + int xp = (int)x; int yp = (int)y; int zp = (int)z; diff --git a/Minecraft.World/GameCommandPacket.cpp b/Minecraft.World/GameCommandPacket.cpp index 37b207d7..0bf54624 100644 --- a/Minecraft.World/GameCommandPacket.cpp +++ b/Minecraft.World/GameCommandPacket.cpp @@ -40,7 +40,7 @@ void GameCommandPacket::read(DataInputStream *dis) command = (EGameCommand)dis->readInt(); length = dis->readShort(); - if (length > 0 && length < Short::MAX_VALUE) + if (length > 0 && length <= Short::MAX_VALUE) { if(data.data != NULL) { diff --git a/Minecraft.World/IntArrayTag.h b/Minecraft.World/IntArrayTag.h index 808b9894..74dc341a 100644 --- a/Minecraft.World/IntArrayTag.h +++ b/Minecraft.World/IntArrayTag.h @@ -35,6 +35,7 @@ public: void load(DataInput *dis, int tagDepth) { int length = dis->readInt(); + if (length < 0 || length > 65536) length = 0; if ( data.data ) delete[] data.data; data = intArray(length); diff --git a/Minecraft.World/LevelChunk.cpp b/Minecraft.World/LevelChunk.cpp index b48b4491..295f9b9a 100644 --- a/Minecraft.World/LevelChunk.cpp +++ b/Minecraft.World/LevelChunk.cpp @@ -1197,7 +1197,6 @@ void LevelChunk::addEntity(shared_ptr e) int zc = Mth::floor(e->z / 16); if (xc != this->x || zc != this->z) { - app.DebugPrintf("Wrong location!"); // System.out.println("Wrong location! " + e); // Thread.dumpStack(); } diff --git a/Minecraft.World/ListTag.h b/Minecraft.World/ListTag.h index 888ca3ad..d7f90122 100644 --- a/Minecraft.World/ListTag.h +++ b/Minecraft.World/ListTag.h @@ -37,11 +37,13 @@ public: } type = dis->readByte(); int size = dis->readInt(); + if (size < 0 || size > 10000) size = 0; list.clear(); for (int i = 0; i < size; i++) { Tag *tag = Tag::newTag(type, L""); + if (tag == NULL) break; tag->load(dis, tagDepth); list.push_back(tag); } diff --git a/Minecraft.World/Packet.cpp b/Minecraft.World/Packet.cpp index a58ebe6e..0f530ef1 100644 --- a/Minecraft.World/Packet.cpp +++ b/Minecraft.World/Packet.cpp @@ -268,7 +268,13 @@ void Packet::updatePacketStatsPIX() shared_ptr Packet::getPacket(int id) { // 4J: Removed try/catch - return idToCreateMap[id](); +#ifdef __PS3__ + boost::unordered_map::iterator it = idToCreateMap.find(id); +#else + auto it = idToCreateMap.find(id); +#endif + if (it == idToCreateMap.end()) return shared_ptr(); + return it->second(); } void Packet::writeBytes(DataOutputStream *dataoutputstream, byteArray bytes) @@ -330,13 +336,12 @@ shared_ptr Packet::readPacket(DataInputStream *dis, bool isServer) // th if ((isServer && serverReceivedPackets.find(id) == serverReceivedPackets.end()) || (!isServer && clientReceivedPackets.find(id) == clientReceivedPackets.end())) { //app.DebugPrintf("Bad packet id %d\n", id); - __debugbreak(); - assert(false); + return nullptr; // throw new IOException(wstring(L"Bad packet id ") + _toString(id)); } packet = getPacket(id); - if (packet == NULL) assert(false);//throw new IOException(wstring(L"Bad packet id ") + _toString(id)); + if (packet == NULL) return nullptr;//throw new IOException(wstring(L"Bad packet id ") + _toString(id)); //app.DebugPrintf("%s reading packet %d\n", isServer ? "Server" : "Client", packet->getId()); packet->read(dis); @@ -394,17 +399,9 @@ wstring Packet::readUtf(DataInputStream *dis, int maxLength) // throws IOExcepti { short stringLength = dis->readShort(); - if (stringLength > maxLength) + if (stringLength > maxLength || stringLength < 0) { - wstringstream stream; - stream << L"Received string length longer than maximum allowed (" << stringLength << " > " << maxLength << ")"; - assert(false); - // throw new IOException( stream.str() ); - } - if (stringLength < 0) - { - assert(false); - // throw new IOException(L"Received string length is less than zero! Weird string!"); + return L""; } wstring builder = L""; @@ -507,7 +504,7 @@ shared_ptr Packet::readItem(DataInputStream *dis) { shared_ptr item = nullptr; int id = dis->readShort(); - if (id >= 0) + if (id >= 0 && id < 32000) // validate against Item::ITEM_NUM_COUNT { int count = dis->readByte(); int damage = dis->readShort(); @@ -545,9 +542,16 @@ void Packet::writeItem(shared_ptr item, DataOutputStream *dos) CompoundTag *Packet::readNbt(DataInputStream *dis) { int size = dis->readShort(); - if (size < 0) return NULL; + if (size <= 0) return NULL; + + const int MAX_NBT_SIZE = 32767; + if (size > MAX_NBT_SIZE) return NULL; byteArray buff(size); - dis->readFully(buff); + if (!dis->readFully(buff)) + { + delete [] buff.data; + return NULL; + } CompoundTag *result = (CompoundTag *) NbtIo::decompress(buff); delete [] buff.data; return result; diff --git a/Minecraft.World/PreLoginPacket.cpp b/Minecraft.World/PreLoginPacket.cpp index 8ce838e0..b357e5a0 100644 --- a/Minecraft.World/PreLoginPacket.cpp +++ b/Minecraft.World/PreLoginPacket.cpp @@ -62,6 +62,7 @@ void PreLoginPacket::read(DataInputStream *dis) //throws IOException m_friendsOnlyBits = dis->readByte(); m_ugcPlayersVersion = dis->readInt(); m_dwPlayerCount = dis->readByte(); + if( m_dwPlayerCount > MINECRAFT_NET_MAX_PLAYERS ) m_dwPlayerCount = MINECRAFT_NET_MAX_PLAYERS; if( m_dwPlayerCount > 0 ) { m_playerXuids = new PlayerUID[m_dwPlayerCount]; @@ -74,6 +75,7 @@ void PreLoginPacket::read(DataInputStream *dis) //throws IOException { m_szUniqueSaveName[i]=dis->readByte(); } + m_szUniqueSaveName[m_iSaveNameLen - 1] = 0; m_serverSettings = dis->readInt(); m_hostIndex = dis->readByte(); diff --git a/Minecraft.World/RemoveEntitiesPacket.cpp b/Minecraft.World/RemoveEntitiesPacket.cpp index b6c75e18..8a978025 100644 --- a/Minecraft.World/RemoveEntitiesPacket.cpp +++ b/Minecraft.World/RemoveEntitiesPacket.cpp @@ -21,7 +21,9 @@ RemoveEntitiesPacket::~RemoveEntitiesPacket() void RemoveEntitiesPacket::read(DataInputStream *dis) //throws IOException { - ids = intArray(dis->readByte()); + int count = dis->readByte(); + if(count < 0) count = 0; + ids = intArray(count); for(unsigned int i = 0; i < ids.length; ++i) { ids[i] = dis->readInt(); diff --git a/Minecraft.World/Socket.cpp b/Minecraft.World/Socket.cpp index fc98101a..1f0fc607 100644 --- a/Minecraft.World/Socket.cpp +++ b/Minecraft.World/Socket.cpp @@ -138,6 +138,11 @@ void Socket::pushDataToQueue(const BYTE * pbData, DWORD dwDataSize, bool fromHos } EnterCriticalSection(&m_queueLockNetwork[queueIdx]); + if(m_queueNetwork[queueIdx].size() + dwDataSize > 2 * 1024 * 1024) + { + LeaveCriticalSection(&m_queueLockNetwork[queueIdx]); + return; + } for( unsigned int i = 0; i < dwDataSize; i++ ) { m_queueNetwork[queueIdx].push(*pbData++); diff --git a/Minecraft.World/SynchedEntityData.cpp b/Minecraft.World/SynchedEntityData.cpp index 8ffda5d8..cd5110e9 100644 --- a/Minecraft.World/SynchedEntityData.cpp +++ b/Minecraft.World/SynchedEntityData.cpp @@ -343,8 +343,10 @@ vector > *SynchedEntityData::unpack(Data vector > *result = NULL; int currentHeader = input->readByte(); + int itemCount = 0; + const int MAX_ENTITY_DATA_ITEMS = 256; - while (currentHeader != EOF_MARKER) + while (currentHeader != EOF_MARKER && itemCount < MAX_ENTITY_DATA_ITEMS) { if (result == NULL) @@ -399,6 +401,7 @@ vector > *SynchedEntityData::unpack(Data break; } result->push_back(item); + itemCount++; currentHeader = input->readByte(); } diff --git a/Minecraft.World/Tag.cpp b/Minecraft.World/Tag.cpp index 0051368d..295751e6 100644 --- a/Minecraft.World/Tag.cpp +++ b/Minecraft.World/Tag.cpp @@ -84,27 +84,48 @@ Tag *Tag::readNamedTag(DataInput *dis) Tag *Tag::readNamedTag(DataInput *dis, int tagDepth) { + static __declspec(thread) int depth = 0; + static __declspec(thread) int totalTagCount = 0; + + if (depth == 0) + totalTagCount = 0; + + depth++; + + if (depth > 256) + { + depth--; + return new EndTag(); + } + + totalTagCount++; + const int MAX_TOTAL_TAGS = 32768; + if (totalTagCount > MAX_TOTAL_TAGS) + { + depth--; + return new EndTag(); + } + byte type = dis->readByte(); - if (type == 0) return new EndTag(); + if (type == 0) { depth--; return new EndTag(); } // 4J Stu - readByte can return -1, so if it's that then also mark as the end tag if(type == 255) { - app.DebugPrintf("readNamedTag read a type of 255\n"); -#ifndef _CONTENT_PACKAGE - __debugbreak(); -#endif + depth--; return new EndTag(); } wstring name = dis->readUTF();//new String(bytes, "UTF-8"); Tag *tag = newTag(type, name); + if (tag == NULL) { depth--; return new EndTag(); } // short length = dis.readShort(); // byte[] bytes = new byte[length]; // dis.readFully(bytes); tag->load(dis, tagDepth); + depth--; return tag; } diff --git a/Minecraft.World/TextureAndGeometryPacket.cpp b/Minecraft.World/TextureAndGeometryPacket.cpp index b6fc6ce7..c3046e37 100644 --- a/Minecraft.World/TextureAndGeometryPacket.cpp +++ b/Minecraft.World/TextureAndGeometryPacket.cpp @@ -123,7 +123,16 @@ void TextureAndGeometryPacket::read(DataInputStream *dis) //throws IOException { textureName = dis->readUTF(); dwSkinID = (DWORD)dis->readInt(); - dwTextureBytes = (DWORD)dis->readShort(); + short rawTextureBytes = dis->readShort(); + if(rawTextureBytes <= 0) + { + dwTextureBytes = 0; + } + else + { + dwTextureBytes = (DWORD)(unsigned short)rawTextureBytes; + if(dwTextureBytes > 65536) dwTextureBytes = 0; + } if(dwTextureBytes>0) { @@ -136,7 +145,16 @@ void TextureAndGeometryPacket::read(DataInputStream *dis) //throws IOException } uiAnimOverrideBitmask = dis->readInt(); - dwBoxC = (DWORD)dis->readShort(); + short rawBoxC = dis->readShort(); + if(rawBoxC <= 0) + { + dwBoxC = 0; + } + else + { + dwBoxC = (DWORD)(unsigned short)rawBoxC; + if(dwBoxC > 256) dwBoxC = 0; // sane limit for skin boxes + } if(dwBoxC>0) { diff --git a/Minecraft.World/TexturePacket.cpp b/Minecraft.World/TexturePacket.cpp index c5eebb0d..34e35da3 100644 --- a/Minecraft.World/TexturePacket.cpp +++ b/Minecraft.World/TexturePacket.cpp @@ -37,16 +37,24 @@ void TexturePacket::handle(PacketListener *listener) void TexturePacket::read(DataInputStream *dis) //throws IOException { textureName = dis->readUTF(); - dwBytes = (DWORD)dis->readShort(); - - if(dwBytes>0) + short rawBytes = dis->readShort(); + if(rawBytes <= 0) { - this->pbData= new BYTE [dwBytes]; + dwBytes = 0; + return; + } + dwBytes = (DWORD)(unsigned short)rawBytes; + if(dwBytes > 65536) + { + dwBytes = 0; + return; + } - for(DWORD i=0;ipbData[i] = dis->readByte(); - } + this->pbData= new BYTE [dwBytes]; + + for(DWORD i=0;ipbData[i] = dis->readByte(); } } diff --git a/Minecraft.World/UpdateGameRuleProgressPacket.cpp b/Minecraft.World/UpdateGameRuleProgressPacket.cpp index 29430bb2..8a2c3d4f 100644 --- a/Minecraft.World/UpdateGameRuleProgressPacket.cpp +++ b/Minecraft.World/UpdateGameRuleProgressPacket.cpp @@ -42,7 +42,7 @@ void UpdateGameRuleProgressPacket::read(DataInputStream *dis) //throws IOExcepti m_dataTag = dis->readInt(); int dataLength = dis->readInt(); - if(dataLength > 0) + if(dataLength > 0 && dataLength <= 65536) { m_data = byteArray(dataLength); dis->readFully(m_data); diff --git a/Minecraft.World/compression.cpp b/Minecraft.World/compression.cpp index 9bbf0a8e..419576c2 100644 --- a/Minecraft.World/compression.cpp +++ b/Minecraft.World/compression.cpp @@ -196,9 +196,20 @@ HRESULT Compression::DecompressLZXRLE(void *pDestination, unsigned int *pDestSiz unsigned int rleSize = staticRleSize; unsigned char *dynamicRleBuf = NULL; - if(*pDestSize > rleSize) + unsigned int safeRleSize = max(rleSize, *pDestSize); + + const unsigned int MAX_RLE_ALLOC = 16 * 1024 * 1024; // 16 MB + if(safeRleSize > MAX_RLE_ALLOC) { - rleSize = *pDestSize; + LeaveCriticalSection(&rleDecompressLock); + *pDestSize = 0; + // E_FAIL doesnt exist on PS3 + return (HRESULT)0x80004005L; + } + + if(safeRleSize > staticRleSize) + { + rleSize = safeRleSize; dynamicRleBuf = new unsigned char[rleSize]; Decompress(dynamicRleBuf, &rleSize, pSource, SrcSize); pucIn = (unsigned char *)dynamicRleBuf; @@ -212,16 +223,19 @@ HRESULT Compression::DecompressLZXRLE(void *pDestination, unsigned int *pDestSiz //unsigned char *pucIn = (unsigned char *)rleDecompressBuf; unsigned char *pucEnd = pucIn + rleSize; unsigned char *pucOut = (unsigned char *)pDestination; + unsigned char *pucOutEnd = pucOut + *pDestSize; while( pucIn != pucEnd ) { unsigned char thisOne = *pucIn++; if( thisOne == 255 ) { + if( pucIn >= pucEnd ) break; unsigned int count = *pucIn++; if( count < 3 ) { count++; + if( pucOut + count > pucOutEnd ) { pucOut = pucOutEnd; break; } for( unsigned int i = 0; i < count; i++ ) { *pucOut++ = 255; @@ -230,7 +244,9 @@ HRESULT Compression::DecompressLZXRLE(void *pDestination, unsigned int *pDestSiz else { count++; + if( pucIn >= pucEnd ) break; unsigned char data = *pucIn++; + if( pucOut + count > pucOutEnd ) { pucOut = pucOutEnd; break; } for( unsigned int i = 0; i < count; i++ ) { *pucOut++ = data; @@ -239,6 +255,7 @@ HRESULT Compression::DecompressLZXRLE(void *pDestination, unsigned int *pDestSiz } else { + if( pucOut >= pucOutEnd ) break; *pucOut++ = thisOne; } } @@ -260,16 +277,19 @@ HRESULT Compression::DecompressRLE(void *pDestination, unsigned int *pDestSize, unsigned char *pucIn = (unsigned char *)pSource; unsigned char *pucEnd = pucIn + SrcSize; unsigned char *pucOut = (unsigned char *)pDestination; + unsigned char *pucOutEnd = pucOut + *pDestSize; while( pucIn != pucEnd ) { unsigned char thisOne = *pucIn++; if( thisOne == 255 ) { + if( pucIn >= pucEnd ) break; unsigned int count = *pucIn++; if( count < 3 ) { count++; + if( pucOut + count > pucOutEnd ) { pucOut = pucOutEnd; break; } for( unsigned int i = 0; i < count; i++ ) { *pucOut++ = 255; @@ -278,7 +298,9 @@ HRESULT Compression::DecompressRLE(void *pDestination, unsigned int *pDestSize, else { count++; + if( pucIn >= pucEnd ) break; unsigned char data = *pucIn++; + if( pucOut + count > pucOutEnd ) { pucOut = pucOutEnd; break; } for( unsigned int i = 0; i < count; i++ ) { *pucOut++ = data; @@ -287,6 +309,7 @@ HRESULT Compression::DecompressRLE(void *pDestination, unsigned int *pDestSize, } else { + if( pucOut >= pucOutEnd ) break; *pucOut++ = thisOne; } } diff --git a/Minecraft.World/x64headers/extraX64.h b/Minecraft.World/x64headers/extraX64.h index d384cbe7..884730ba 100644 --- a/Minecraft.World/x64headers/extraX64.h +++ b/Minecraft.World/x64headers/extraX64.h @@ -249,6 +249,9 @@ private: }; void Win64_SetupRemoteQNetPlayer(IQNetPlayer *player, BYTE smallId, bool isHost, bool isLocal); +char GetUsername(); +PlayerUID Win64_UsernameToXuid(const char* username); +PlayerUID Win64_UsernameToXuid(const wchar_t* username); const int QNET_GETSENDQUEUESIZE_SECONDARY_TYPE = 0; const int QNET_GETSENDQUEUESIZE_MESSAGES = 0;