From 5271a27e1223a4ca12a6e5b3916c84e52d2cd3d0 Mon Sep 17 00:00:00 2001
From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com>
Date: Sat, 8 Aug 2026 18:32:13 -0400
Subject: [PATCH] chore: update docs & speed up builds
---
.gitea/IMPLEMENTATION_GUIDE.md | 22 ++++++++++++----------
4J_Input/4J_Input.vcxproj | 7 +++++++
4J_Profile/4J_Profile.vcxproj | 3 +++
4J_Render/4J_Render.vcxproj | 3 +++
4J_Storage/4J_Storage.vcxproj | 3 +++
5 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/.gitea/IMPLEMENTATION_GUIDE.md b/.gitea/IMPLEMENTATION_GUIDE.md
index 64a8251..3701116 100644
--- a/.gitea/IMPLEMENTATION_GUIDE.md
+++ b/.gitea/IMPLEMENTATION_GUIDE.md
@@ -10,7 +10,7 @@ This guide will explain every change you can do in the source leak to improve it
#### The original code for displaying and saving thumbnails was broken for the Windows platform, either by poor ports or lack of care, in this section it will be explained how to enable this feature for the Windows platform using 4JLibs
-In the files ``ConsoleSaveFileOriginal.cpp`` and ``ConsoleSaveFileSplit.cpp`` (the latter might not exist if you are using the December build) there was a mistake when calling ``app.GetSaveThumbnail``
+In the files ``ConsoleSaveFileOriginal.cpp`` and ``ConsoleSaveFileSplit.cpp`` there was a mistake when calling ``app.GetSaveThumbnail``
To fix this issue, you need to replace the line of code:
@@ -84,10 +84,10 @@ Then, below that, there's the following chunk of code:
You want to modify the ``#else`` conditional to be:
```cpp
-#elif defined(__ORBIS__) || defined(__PSVITA__)
+#elif defined(__ORBIS__)
```
-This way the Windows platform doesn't try accessing PS4/PSVita functions
+This way the Windows platform doesn't try accessing PS4 functions
Then you want to comment/remove the following chunk of code:
```cpp
@@ -102,13 +102,15 @@ Then you want to comment/remove the following chunk of code:
You can replace it for
```cpp
- //if(params->saveDetails->pbThumbnailData)
- //{
- // m_pbThumbnailData = params->saveDetails->pbThumbnailData;
- // m_uiThumbnailSize = params->saveDetails->dwThumbnailSize;
- // m_bSaveThumbnailReady = true;
- //}
- //else
+#ifndef _WINDOWS64
+ if(params->saveDetails->pbThumbnailData)
+ {
+ m_pbThumbnailData = params->saveDetails->pbThumbnailData;
+ m_uiThumbnailSize = params->saveDetails->dwThumbnailSize;
+ m_bSaveThumbnailReady = true;
+ }
+ else
+#endif
```
This is because, for a ``SAVE_DETAILS`` object, the thumbnail data is always pointing to valid memory (aka, it's always allocated)
diff --git a/4J_Input/4J_Input.vcxproj b/4J_Input/4J_Input.vcxproj
index a47419d..eed1ec1 100644
--- a/4J_Input/4J_Input.vcxproj
+++ b/4J_Input/4J_Input.vcxproj
@@ -121,11 +121,15 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreadedDebug
+ true
+ false
+ CompileAsCppWindowstrue
+
@@ -157,6 +161,8 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreaded
+ true
+ CompileAsCppWindows
@@ -164,6 +170,7 @@
truetrue
+
diff --git a/4J_Profile/4J_Profile.vcxproj b/4J_Profile/4J_Profile.vcxproj
index 5296206..a641a60 100644
--- a/4J_Profile/4J_Profile.vcxproj
+++ b/4J_Profile/4J_Profile.vcxproj
@@ -122,6 +122,8 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreadedDLL
+ true
+ falseWindows
@@ -159,6 +161,7 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreaded
+ trueWindows
diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj
index 262c8cf..1aa1c53 100644
--- a/4J_Render/4J_Render.vcxproj
+++ b/4J_Render/4J_Render.vcxproj
@@ -153,6 +153,8 @@
stdafx.hCompileAsCppMultiThreadedDLL
+ true
+ falseWindows
@@ -198,6 +200,7 @@
stdafx.hMultiThreadedCompileAsCpp
+ trueWindows
diff --git a/4J_Storage/4J_Storage.vcxproj b/4J_Storage/4J_Storage.vcxproj
index 2875803..1bdc21c 100644
--- a/4J_Storage/4J_Storage.vcxproj
+++ b/4J_Storage/4J_Storage.vcxproj
@@ -118,6 +118,8 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreadedDebug
+ true
+ falseWindows
@@ -155,6 +157,7 @@
../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories)stdafx.hMultiThreaded
+ trueWindows