From de797a5c6f461720c62f54fb8afcb42e0af1441e Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 14:53:52 -0400 Subject: [PATCH 1/6] feat: no mo pch --- 4J_Input/4J_Input.vcxproj | 2 -- 4J_Profile/4J_Profile.vcxproj | 4 ++-- 4J_Render/4J_Render.vcxproj | 4 ++-- 4J_Storage/4J_Storage.vcxproj | 4 ++-- 4J_XTMS/4J_XTMS.vcxproj | 4 ++-- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/4J_Input/4J_Input.vcxproj b/4J_Input/4J_Input.vcxproj index 409fee7..a47419d 100644 --- a/4J_Input/4J_Input.vcxproj +++ b/4J_Input/4J_Input.vcxproj @@ -114,7 +114,6 @@ - Create Level3 Disabled _WINDOWS64;_DEBUG;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) @@ -150,7 +149,6 @@ Level3 - Create MaxSpeed true true diff --git a/4J_Profile/4J_Profile.vcxproj b/4J_Profile/4J_Profile.vcxproj index 28dc999..5296206 100644 --- a/4J_Profile/4J_Profile.vcxproj +++ b/4J_Profile/4J_Profile.vcxproj @@ -114,7 +114,7 @@ - Create + NotUsing Level3 Disabled WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions) @@ -150,7 +150,7 @@ Level3 - Create + NotUsing MaxSpeed true true diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj index edf8281..262c8cf 100644 --- a/4J_Render/4J_Render.vcxproj +++ b/4J_Render/4J_Render.vcxproj @@ -144,7 +144,7 @@ - Create + NotUsing Level3 Disabled _WINDOWS64;_DEBUG;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) @@ -188,7 +188,7 @@ Level3 - Create + NotUsing MaxSpeed true true diff --git a/4J_Storage/4J_Storage.vcxproj b/4J_Storage/4J_Storage.vcxproj index 8d357ca..2875803 100644 --- a/4J_Storage/4J_Storage.vcxproj +++ b/4J_Storage/4J_Storage.vcxproj @@ -110,7 +110,7 @@ - Create + NotUsing Level3 Disabled _WINDOWS64;_DEBUG;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) @@ -146,7 +146,7 @@ Level3 - Create + NotUsing MaxSpeed true true diff --git a/4J_XTMS/4J_XTMS.vcxproj b/4J_XTMS/4J_XTMS.vcxproj index a986cfa..d4838bf 100644 --- a/4J_XTMS/4J_XTMS.vcxproj +++ b/4J_XTMS/4J_XTMS.vcxproj @@ -89,7 +89,7 @@ - Create + NotUsing Level3 Disabled _WINDOWS64;_DEBUG;_LIB;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions) @@ -125,7 +125,7 @@ Level3 - Create + NotUsing MaxSpeed true true From 5271a27e1223a4ca12a6e5b3916c84e52d2cd3d0 Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 18:32:13 -0400 Subject: [PATCH 2/6] chore: update docs & speed up builds --- .gitea/IMPLEMENTATION_GUIDE.md | 22 ++++++++++++---------- 4J_Input/4J_Input.vcxproj | 7 +++++++ 4J_Profile/4J_Profile.vcxproj | 3 +++ 4J_Render/4J_Render.vcxproj | 3 +++ 4J_Storage/4J_Storage.vcxproj | 3 +++ 5 files changed, 28 insertions(+), 10 deletions(-) diff --git a/.gitea/IMPLEMENTATION_GUIDE.md b/.gitea/IMPLEMENTATION_GUIDE.md index 64a8251..3701116 100644 --- a/.gitea/IMPLEMENTATION_GUIDE.md +++ b/.gitea/IMPLEMENTATION_GUIDE.md @@ -10,7 +10,7 @@ This guide will explain every change you can do in the source leak to improve it #### The original code for displaying and saving thumbnails was broken for the Windows platform, either by poor ports or lack of care, in this section it will be explained how to enable this feature for the Windows platform using 4JLibs -In the files ``ConsoleSaveFileOriginal.cpp`` and ``ConsoleSaveFileSplit.cpp`` (the latter might not exist if you are using the December build) there was a mistake when calling ``app.GetSaveThumbnail`` +In the files ``ConsoleSaveFileOriginal.cpp`` and ``ConsoleSaveFileSplit.cpp`` there was a mistake when calling ``app.GetSaveThumbnail`` To fix this issue, you need to replace the line of code: @@ -84,10 +84,10 @@ Then, below that, there's the following chunk of code: You want to modify the ``#else`` conditional to be: ```cpp -#elif defined(__ORBIS__) || defined(__PSVITA__) +#elif defined(__ORBIS__) ``` -This way the Windows platform doesn't try accessing PS4/PSVita functions +This way the Windows platform doesn't try accessing PS4 functions Then you want to comment/remove the following chunk of code: ```cpp @@ -102,13 +102,15 @@ Then you want to comment/remove the following chunk of code: You can replace it for ```cpp - //if(params->saveDetails->pbThumbnailData) - //{ - // m_pbThumbnailData = params->saveDetails->pbThumbnailData; - // m_uiThumbnailSize = params->saveDetails->dwThumbnailSize; - // m_bSaveThumbnailReady = true; - //} - //else +#ifndef _WINDOWS64 + if(params->saveDetails->pbThumbnailData) + { + m_pbThumbnailData = params->saveDetails->pbThumbnailData; + m_uiThumbnailSize = params->saveDetails->dwThumbnailSize; + m_bSaveThumbnailReady = true; + } + else +#endif ``` This is because, for a ``SAVE_DETAILS`` object, the thumbnail data is always pointing to valid memory (aka, it's always allocated) diff --git a/4J_Input/4J_Input.vcxproj b/4J_Input/4J_Input.vcxproj index a47419d..eed1ec1 100644 --- a/4J_Input/4J_Input.vcxproj +++ b/4J_Input/4J_Input.vcxproj @@ -121,11 +121,15 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreadedDebug + true + false + CompileAsCpp Windows true + @@ -157,6 +161,8 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreaded + true + CompileAsCpp Windows @@ -164,6 +170,7 @@ true true + diff --git a/4J_Profile/4J_Profile.vcxproj b/4J_Profile/4J_Profile.vcxproj index 5296206..a641a60 100644 --- a/4J_Profile/4J_Profile.vcxproj +++ b/4J_Profile/4J_Profile.vcxproj @@ -122,6 +122,8 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreadedDLL + true + false Windows @@ -159,6 +161,7 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreaded + true Windows diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj index 262c8cf..1aa1c53 100644 --- a/4J_Render/4J_Render.vcxproj +++ b/4J_Render/4J_Render.vcxproj @@ -153,6 +153,8 @@ stdafx.h CompileAsCpp MultiThreadedDLL + true + false Windows @@ -198,6 +200,7 @@ stdafx.h MultiThreaded CompileAsCpp + true Windows diff --git a/4J_Storage/4J_Storage.vcxproj b/4J_Storage/4J_Storage.vcxproj index 2875803..1bdc21c 100644 --- a/4J_Storage/4J_Storage.vcxproj +++ b/4J_Storage/4J_Storage.vcxproj @@ -118,6 +118,8 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreadedDebug + true + false Windows @@ -155,6 +157,7 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h MultiThreaded + true Windows From d086428ecaf6225a89a85d4a184b7e24fcc7f135 Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 18:33:49 -0400 Subject: [PATCH 3/6] chore: update .gitignore --- .gitignore | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 8954b22..d3bd8a2 100644 --- a/.gitignore +++ b/.gitignore @@ -7,4 +7,7 @@ ipch/ *.suo *.opensdf VS_* -/libs + +# Output Folders +libs/ +inc/ From 961be9d9f781f5ae83d9c7b39c4219e6354f2666 Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 20:55:29 -0400 Subject: [PATCH 4/6] fix: Debug linker error --- 4J_Render/4J_Render.vcxproj | 1 + 1 file changed, 1 insertion(+) diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj index 1aa1c53..29393e0 100644 --- a/4J_Render/4J_Render.vcxproj +++ b/4J_Render/4J_Render.vcxproj @@ -136,6 +136,7 @@ true ../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h + MultiThreadedDebug Windows From 85cfea295f00785a7485b5c39a63c6a59714e138 Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 21:04:28 -0400 Subject: [PATCH 5/6] Revert "fix: Debug linker error" This reverts commit 961be9d9f781f5ae83d9c7b39c4219e6354f2666. --- 4J_Render/4J_Render.vcxproj | 1 - 1 file changed, 1 deletion(-) diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj index 29393e0..1aa1c53 100644 --- a/4J_Render/4J_Render.vcxproj +++ b/4J_Render/4J_Render.vcxproj @@ -136,7 +136,6 @@ true ../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h - MultiThreadedDebug Windows From dc962f2931bb15c6d34d4cf2a3e5e08460be5290 Mon Sep 17 00:00:00 2001 From: str1k3r <115313679+S1l3ntStr1ke87@users.noreply.github.com> Date: Sat, 8 Aug 2026 21:05:07 -0400 Subject: [PATCH 6/6] fix: Debug linker error --- 4J_Render/4J_Render.vcxproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/4J_Render/4J_Render.vcxproj b/4J_Render/4J_Render.vcxproj index 1aa1c53..1babd17 100644 --- a/4J_Render/4J_Render.vcxproj +++ b/4J_Render/4J_Render.vcxproj @@ -152,7 +152,7 @@ ../Headers/Windows64;../Headers;$(ProjectDir);%(AdditionalIncludeDirectories) stdafx.h CompileAsCpp - MultiThreadedDLL + MultiThreadedDebug true false